Require authentication on websocket connection level #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2a8c614 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
johnshearar
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For websocket connections, the authentication token is provided on the connection setup (RSocket SETUP frame).
The current implementation parsed the token in the connection setup via the
contextProvider, but only checked that it was valid in the RSocket stream. It would then close the RSocket stream if authentication failed, while the websocket itself stayed open.This now adds the same validation on the connection level via the
contextProvider. This causes the entire websocket to be closed when authentication fails.We have no websocket routes using anonymous authentication, so proper per-route auth is not a consideration now.
There is probably a bug on journey-js as well. It appears to currently re-create the entire connection if a RSocket stream errors, without closing the previous connection.
Combining those two issues, in some cases the client would retry every 5 seconds, get an auth error each time, but keep the old connections open. This then quickly runs into the connection limits on the server, resulting in SERVER_BUSY errors.